Skip to content

Replace dprint with rumdl for MD#1680

Open
kevgo wants to merge 6 commits intomainfrom
rumdl
Open

Replace dprint with rumdl for MD#1680
kevgo wants to merge 6 commits intomainfrom
rumdl

Conversation

@kevgo
Copy link
Copy Markdown
Owner

@kevgo kevgo commented Mar 21, 2026

No description provided.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread Makefile

fix: tools/rta@${RUN_THAT_APP_VERSION} # runs all auto-fixes
yarn exec --silent -- dprint fmt
yarn exec --silent -- rumdl fmt .
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root-level YAML formatting lost after replacing dprint command

Medium Severity

The fix target replaced dprint fmt entirely with rumdl fmt ., but dprint fmt was responsible for both Markdown and YAML formatting. Now only Markdown formatting runs via rumdl. The root dprint.json still contains the YAML plugin and config, but dprint fmt is never invoked from the root Makefile, so YAML files (e.g., under .github/workflows/) silently stop being formatted. A dprint fmt call likely needs to remain alongside rumdl fmt ..

Additional Locations (1)
Fix in Cursor Fix in Web

Comment thread dprint.json
"https://plugins.dprint.dev/markdown-0.18.0.wasm",
"https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.0.wasm"
],
"plugins": ["https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.0.wasm"],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sub-package markdown formatting lost after plugin removal

Medium Severity

Removing the markdown plugin from dprint.json breaks markdown formatting and linting in all sub-packages (textrun-action, textrun-extension, textrun-javascript, textrun-make, textrun-npm, textrun-repo, textrun-shell, textrun-workspace, text-runner-engine) that still call dprint fmt/dprint check in their fix/lint scripts. These packages also appear in .rumdl.toml's exclude list, so rumdl fmt . doesn't cover them either. Markdown in these sub-packages is now silently unformatted and unchecked by any tool.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant