Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| fix: tools/rta@${RUN_THAT_APP_VERSION} # runs all auto-fixes | ||
| yarn exec --silent -- dprint fmt | ||
| yarn exec --silent -- rumdl fmt . |
There was a problem hiding this comment.
Root-level YAML formatting lost after replacing dprint command
Medium Severity
The fix target replaced dprint fmt entirely with rumdl fmt ., but dprint fmt was responsible for both Markdown and YAML formatting. Now only Markdown formatting runs via rumdl. The root dprint.json still contains the YAML plugin and config, but dprint fmt is never invoked from the root Makefile, so YAML files (e.g., under .github/workflows/) silently stop being formatted. A dprint fmt call likely needs to remain alongside rumdl fmt ..
Additional Locations (1)
| "https://plugins.dprint.dev/markdown-0.18.0.wasm", | ||
| "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.0.wasm" | ||
| ], | ||
| "plugins": ["https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.0.wasm"], |
There was a problem hiding this comment.
Sub-package markdown formatting lost after plugin removal
Medium Severity
Removing the markdown plugin from dprint.json breaks markdown formatting and linting in all sub-packages (textrun-action, textrun-extension, textrun-javascript, textrun-make, textrun-npm, textrun-repo, textrun-shell, textrun-workspace, text-runner-engine) that still call dprint fmt/dprint check in their fix/lint scripts. These packages also appear in .rumdl.toml's exclude list, so rumdl fmt . doesn't cover them either. Markdown in these sub-packages is now silently unformatted and unchecked by any tool.


No description provided.